Skip to content

Issue 7322 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2025
Merged

Issue 7322 #472

merged 5 commits into from
Jan 20, 2025

Conversation

@aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Jan 20, 2025

Description

Added ibm_catalog.json and .catalog-onboard-pipeline.yaml.
Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added ibm_catalog.json and .catalog-onboard-pipeline.yaml.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

aatreyee2506 commented Jan 20, 2025

/run pipeline

ocofaigh
ocofaigh requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

ocofaigh
ocofaigh requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the .releaserc file so it triggers the catalog publish pipeline upon the creation of every new release for example see here)

@aatreyee2506
Copy link
Contributor Author

aatreyee2506 commented Jan 20, 2025

/run pipeline

ocofaigh
ocofaigh requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@aatreyee2506
Copy link
Contributor Author

aatreyee2506 commented Jan 20, 2025

/run pipeline

@ocofaigh ocofaigh merged commit b5110f1 into main Jan 20, 2025
2 checks passed
@ocofaigh ocofaigh deleted the issue_7322 branch January 20, 2025 18:10
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Jan 20, 2025

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@rajatagarwal-ibm rajatagarwal-ibm Awaiting requested review from rajatagarwal-ibm rajatagarwal-ibm is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aatreyee2506 @terraform-ibm-modules-ops @ocofaigh